| commit | 19663843f4fc612f73df8ba970800f2f1a5166a2 | [log] [tgz] |
|---|---|---|
| author | Jim Hahn <jrh3@att.com> | Tue Apr 07 09:18:12 2020 -0400 |
| committer | Jim Hahn <jrh3@att.com> | Tue Apr 07 11:59:10 2020 -0400 |
| tree | 47176d60279a21cd975831b433227917d43de39b | |
| parent | ece155048af47ea83ff898c999aa5137dc99a988 [diff] |
Address sonar issues in policy-management
Addressed the following sonar issues:
- modified code to specify the correct class name in the
getLogger() call
- use equals() instead of "==" for string comparison
- remove deprecated code
- use ',' instead of "," in indexOf
- remove code that is commented out; typically bogus, so the comment
was adjusted to satisfy sonar
- missing assert in junits
- use "{}" instead of concatenation when using logger
- either log or rethrow
- put arguments for assertEquals() in the correct order
- remove "return" statements from the end of void methods
- don't always return the same value; just disabled sonar as
refactoring would have obfuscated the code
- cognitive complexity; used eclipse auto-refactoring to extract
out chunks of code into separate methods
- don't pass array of classes to class.getDeclaredMethod(); use
ellided arguments instead
- fix argument count in logger calls
- remove unnecessary casts
- don't use "volatile"
- make methods "synchronized" to match parent class definitions
Issue-ID: POLICY-2305
Change-Id: Ie96418f696da4ae6c2ca8d4a914371469e695419
Signed-off-by: Jim Hahn <jrh3@att.com>
Copyright 2018 AT&T Intellectual Property. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode
This source repository contains the ONAP Policy DroolsPDP code. To build it: