| commit | 59e9b9a8b56d563814ef21a23716959f772f9194 | [log] [tgz] |
|---|---|---|
| author | Jim Hahn <jrh3@att.com> | Wed Aug 14 17:31:50 2019 -0400 |
| committer | Jim Hahn <jrh3@att.com> | Thu Aug 15 11:23:31 2019 -0400 |
| tree | f152aea1578a82737501f56916ca07d8e7889d18 | |
| parent | a156cf3cbad6512510ae9a02a13c0408f901c734 [diff] |
Fix more sonar issues in drools-pdp Addressed issues of cyclomatic complexity and deep nesting by refactoring code into separate methods. In some cases, had to refactor the code into nested classes to avoid passing too many parameters to the newly extracted methods. Addressed issue "too many conditionals" by breaking conditionals apart. Addressed issue "Remove usage of generic wildcard type" by eliminating "? extends" from return values. Addressed issue "Remove this use of 'Thread.sleep()'" in junit tests by introducing latches or using Awaitility. Note: this won't build until ApiUtils has been merged. Change-Id: I0d5596b4cb918a36bc22f426f426bd238195b458 Issue-ID: POLICY-1968 Signed-off-by: Jim Hahn <jrh3@att.com>
Copyright 2018 AT&T Intellectual Property. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode
This source repository contains the ONAP Policy DroolsPDP code. To build it: