| commit | 9b3ff5f270572a6760ff07dda9577cdadb53b088 | [log] [tgz] |
|---|---|---|
| author | Jim Hahn <jrh3@att.com> | Tue Apr 07 13:58:09 2020 -0400 |
| committer | Jim Hahn <jrh3@att.com> | Tue Apr 07 17:15:07 2020 -0400 |
| tree | eacd325199fbb72fddaba94a057178a19e9c3360 | |
| parent | 3000fdca611c32b7001c553621660b8ea0d2eb49 [diff] |
Address sonar issues in models
Addressed the following sonar issues:
- use RE2 instead of java.util Pattern for "+" and "*"
- don't use deprecated methods
- for Date(long), sonar appeared not to parse the argument's
type correctly. Modified the code slightly to make sonar happy
- duplicate blocks of code
- either log or throw
- missing assert in junit
- for SDNR & VFC, eliminated threads, as they are unnecessary
- duplicate code block in different branches
- useless assignments
- redeclaring abstract methods
- cyclomatic complexity
- used lombok in some cases (e.g., EqualsAndHashCode)
- assert argument order
- actually deleted ControlLoopTargetType, because it is not needed
and sonar complains regardless of which order is used
- add private constructor to utility classes
- use StandardCharsets instead of literals
Also:
- added logback-test.xml to SO to eliminate the voluminous output
from the junit test
Issue-ID: POLICY-2305
Change-Id: I586c331781bedbd54a115a71847d04d293689445
Signed-off-by: Jim Hahn <jrh3@att.com>
Copyright 2018 AT&T Intellectual Property. All rights reserved. This file is licensed under the CREATIVE COMMONS ATTRIBUTION 4.0 INTERNATIONAL LICENSE Full license text at https://creativecommons.org/licenses/by/4.0/legalcode
This source repository contains the ONAP Policy Model code that is agnostic to any PDP. It is common amongst all the repositories.
To build it using Maven 3, run: mvn clean install