Refactor: JJB code
- Fix shellcheck errors: SC1090, SC2164 and warnings
- Refactor yaml to standardize it across the repo with prettier
- Refactor with yamllint
Change-Id: Ie36c4a3af173fa3609cd4e904775be54b4a56990
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
diff --git a/jjb/ric-plt-alarm-go/ric-plt-alarm-go.yaml b/jjb/ric-plt-alarm-go/ric-plt-alarm-go.yaml
index c489dfc..e936ae8 100755
--- a/jjb/ric-plt-alarm-go/ric-plt-alarm-go.yaml
+++ b/jjb/ric-plt-alarm-go/ric-plt-alarm-go.yaml
@@ -13,8 +13,7 @@
jobs:
- gerrit-info-yaml-verify
-- _alarm_go_common: &alarm_go_common
- # values apply to all projects
+- _alarm_go_common: &alarm_go_common # values apply to all projects
name: alarm-go-common
# git repo
project: ric-plt/alarm-go
@@ -27,18 +26,18 @@
<<: *alarm_go_common
name: ric-plt-alarm-go-docker
# image name
- docker-name: 'o-ran-sc/ric-plt-alarmmanager'
+ docker-name: "o-ran-sc/ric-plt-alarmmanager"
# source of docker tag
container-tag-method: yaml-file
container-tag-yaml-dir: build
# use host network
- docker-build-args: '-f build/Dockerfile --network=host'
+ docker-build-args: "-f build/Dockerfile --network=host"
build-node: ubuntu1804-docker-4c-4g
stream:
- master:
branch: master
jobs:
- - '{project-name}-gerrit-docker-jobs'
+ - "{project-name}-gerrit-docker-jobs"
- project:
<<: *alarm_go_common
@@ -50,23 +49,23 @@
sonar-project-file: ""
# use sonarcloud values from defaults.yaml
sonar-properties: |
- # Required metadata
- sonar.login={sonarcloud_api_token}
- sonar.projectKey={sonarcloud_project_organization}_{project-name}
- sonar.projectName={project-name}
- sonar.organization={sonarcloud_project_organization}
- # Encoding
- sonar.build.sourceEncoding=UTF-8
- # Language
- sonar.language=go
- # Source
- sonar.sources=.
- # Unit tests
- sonar.go.coverage.reportPaths=manager/cover.out,alarm/cover.out
- # Inclusions
- sonar.inclusions=**/*.go
- # Exclusions
- sonar.exclusions=**/*_test.go
+ # Required metadata
+ sonar.login={sonarcloud_api_token}
+ sonar.projectKey={sonarcloud_project_organization}_{project-name}
+ sonar.projectName={project-name}
+ sonar.organization={sonarcloud_project_organization}
+ # Encoding
+ sonar.build.sourceEncoding=UTF-8
+ # Language
+ sonar.language=go
+ # Source
+ sonar.sources=.
+ # Unit tests
+ sonar.go.coverage.reportPaths=manager/cover.out,alarm/cover.out
+ # Inclusions
+ sonar.inclusions=**/*.go
+ # Exclusions
+ sonar.exclusions=**/*_test.go
jobs:
- gerrit-sonar-prescan-script
@@ -75,4 +74,4 @@
name: ric-plt-alarm-go-release
build-node: centos7-docker-2c-8g
jobs:
- - '{project-name}-gerrit-release-jobs'
+ - "{project-name}-gerrit-release-jobs"