Refactor: JJB code

- Fix shellcheck errors: SC1090, SC2164 and warnings
- Refactor yaml to standardize it across the repo with prettier
- Refactor with yamllint

Change-Id: Ie36c4a3af173fa3609cd4e904775be54b4a56990
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
diff --git a/jjb/ric-plt-sdlgo/prescan-sdlgo-go-ubuntu.sh b/jjb/ric-plt-sdlgo/prescan-sdlgo-go-ubuntu.sh
index 18d4d54..fab3f08 100644
--- a/jjb/ric-plt-sdlgo/prescan-sdlgo-go-ubuntu.sh
+++ b/jjb/ric-plt-sdlgo/prescan-sdlgo-go-ubuntu.sh
@@ -44,6 +44,7 @@
 export CFG_FILE=../config/config-file.json
 export RMR_SEED_RT=../config/uta_rtg.rt
 
+# shellcheck disable=SC2034
 GO111MODULE=on GO_ENABLED=0 GOOS=linux
 
 # setup version tag
@@ -51,9 +52,11 @@
 then
     tag=$(grep "tag:" container-tag.yaml | awk '{print $2}')
 else
+    # shellcheck disable=SC2034
     tag="no-tag-found"
 fi
 
+# shellcheck disable=SC2034
 hash=$(git rev-parse --short HEAD || true)
 
 # Build