Refactor: JJB code
- Fix shellcheck errors: SC1090, SC2164 and warnings
- Refactor yaml to standardize it across the repo with prettier
- Refactor with yamllint
Change-Id: Ie36c4a3af173fa3609cd4e904775be54b4a56990
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
diff --git a/jjb/ric-plt-sdlgo/ric-plt-sdlgo.yaml b/jjb/ric-plt-sdlgo/ric-plt-sdlgo.yaml
index 60ae371..e409e89 100644
--- a/jjb/ric-plt-sdlgo/ric-plt-sdlgo.yaml
+++ b/jjb/ric-plt-sdlgo/ric-plt-sdlgo.yaml
@@ -13,8 +13,8 @@
jobs:
- gerrit-info-yaml-verify
-- _sdlgo_docker_common: &sdlgo_docker_common
- # values apply to all sdlgo docker projects
+- _sdlgo_docker_common:
+ &sdlgo_docker_common # values apply to all sdlgo docker projects
name: sdlgo-docker-common
# git repo
project: ric-plt/sdlgo
@@ -28,9 +28,9 @@
<<: *sdlgo_docker_common
name: ric-plt-sdlgo
# image name, altho it is never pushed
- docker-name: '{name}'
+ docker-name: "{name}"
# use host network
- docker-build-args: '--network=host -f ci/Dockerfile'
+ docker-build-args: "--network=host -f ci/Dockerfile"
# image tag; use a fixed value
container-tag-method: latest
jobs:
@@ -48,23 +48,23 @@
sonar-project-file: ""
# use sonarcloud values from defaults.yaml
sonar-properties: |
- # Required metadata
- sonar.login={sonarcloud_api_token}
- sonar.projectKey={sonarcloud_project_organization}_{project-name}
- sonar.projectName={project-name}
- sonar.organization={sonarcloud_project_organization}
- # Encoding
- sonar.build.sourceEncoding=UTF-8
- # Language
- sonar.language=go
- # Source
- sonar.sources=.
- # Unit tests
- sonar.go.coverage.reportPaths=**/cover.out
- # Inclusions
- sonar.inclusions=**/*.go
- # Exclusions
- sonar.exclusions=cmd/**.go,example/**.go,internal/mocks/**.go,**/*_test.go
+ # Required metadata
+ sonar.login={sonarcloud_api_token}
+ sonar.projectKey={sonarcloud_project_organization}_{project-name}
+ sonar.projectName={project-name}
+ sonar.organization={sonarcloud_project_organization}
+ # Encoding
+ sonar.build.sourceEncoding=UTF-8
+ # Language
+ sonar.language=go
+ # Source
+ sonar.sources=.
+ # Unit tests
+ sonar.go.coverage.reportPaths=**/cover.out
+ # Inclusions
+ sonar.inclusions=**/*.go
+ # Exclusions
+ sonar.exclusions=cmd/**.go,example/**.go,internal/mocks/**.go,**/*_test.go
jobs:
- gerrit-sonar-prescan-script
@@ -73,4 +73,4 @@
name: ric-plt-sdlgo-go-release
build-node: centos7-docker-2c-8g
jobs:
- - '{project-name}-gerrit-release-jobs'
+ - "{project-name}-gerrit-release-jobs"