Refactor: JJB code

- Fix shellcheck errors: SC1090, SC2164 and warnings
- Refactor yaml to standardize it across the repo with prettier
- Refactor with yamllint

Change-Id: Ie36c4a3af173fa3609cd4e904775be54b4a56990
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
diff --git a/jjb/smo-o2/smo-o2.yaml b/jjb/smo-o2/smo-o2.yaml
index 1c5d44f..e4fa69f 100644
--- a/jjb/smo-o2/smo-o2.yaml
+++ b/jjb/smo-o2/smo-o2.yaml
@@ -13,8 +13,7 @@
     jobs:
       - gerrit-info-yaml-verify
 
-- _smo_o2_common: &smo_o2_common
-    # values apply to all projects
+- _smo_o2_common: &smo_o2_common # values apply to all projects
     name: smo-o2-common
     # git repo
     project: smo/o2
@@ -29,12 +28,12 @@
 - project:
     <<: *smo_o2_common
     name: smo-o2-release
-    project-name: '{name}'
+    project-name: "{name}"
     # maven release requires sigul which requires centos
     # container release requires docker
     build-node: centos7-docker-2c-8g
     jobs:
-      - '{project-name}-gerrit-release-jobs'
+      - "{project-name}-gerrit-release-jobs"
 
 - project:
     <<: *smo_o2_common