Unit test improvements, add example programme
This change addresses some sonar flagged issues (move/copy
builders missing), and adds unit tests to support the
addition of those. The code was slightly adjusted to
better support testing coverage.
The rmr_dump programme was added to the examples.
Issue-ID: RIC-148
Signed-off-by: E. Scott Daniels <daniels@research.att.com>
Change-Id: I9220d75fa6690feebf439cfe97dda43572f20c4e
diff --git a/src/xapp/xapp.cpp b/src/xapp/xapp.cpp
index 02cea30..8feb52e 100644
--- a/src/xapp/xapp.cpp
+++ b/src/xapp/xapp.cpp
@@ -55,7 +55,7 @@
If port is nil, then the default port is used (4560).
*/
Xapp::Xapp( char* port, bool wait4table ) : Messenger( port, wait4table ) {
- // what's left to do?
+ // nothing to do; all handled in Messenger constructor
}
/*
@@ -72,7 +72,6 @@
function won't return unless that listener crashes.
*/
void Xapp::Run( int nthreads ) {
- int joined; // at end, number of threads joined back
int i;
std::thread** tinfo; // each thread we'll start
@@ -87,6 +86,8 @@
for( i = 0; i < nthreads - 1; i++ ) { // wait for others to stop
tinfo[i]->join();
}
+
+ delete tinfo;
}
/*