commit 456a3197757c5e21f57a44192a0dab163b69b6fd
author Dominik DL6ER <dl6er@dl6er.de> Sun Oct 20 18:51:52 2019 +0200
committer Simon Kelley <simon@thekelleys.org.uk> Fri Oct 25 22:00:35 2019 +0100
tree 52c75eace6a46e686b29327b8a0ccceec14e1ba6
parent 157d8cfd6a467a44ae0145ed8007819c3e3d2660

DHCPv6 IAID should be of unsigned type. It is derived from strtoul() in lease.c:read_leases() and already now interpreted as unsigned in helper.c:276 and outpacket.c:put_opt6_long(). RFC3315 (section 22.4) shows that the IAID is 4 bytes long so we do not need to go up to unsigned long.

Signed-off-by: Dominik DL6ER <dl6er@dl6er.de>

src/helper.c

diff --git a/src/helper.c b/src/helper.c
index c392eec..62ac9cf 100644
--- a/src/helper.c
+++ b/src/helper.c
@@ -66,7 +66,8 @@
 #endif
   struct in6_addr addr6;
 #ifdef HAVE_DHCP6
-  int iaid, vendorclass_count;
+  int vendorclass_count;
+  unsigned int iaid;
 #endif
   unsigned char hwaddr[DHCP_CHADDR_MAX];
   char interface[IF_NAMESIZE];