commit 486bcd5a7b533549257e8cf59214a2f2c099faf9
author Kurt H Maier <khm@sciops.net> Fri Jan 26 15:10:59 2018 +0000
committer Simon Kelley <simon@thekelleys.org.uk> Fri Jan 26 15:10:59 2018 +0000
tree 44661f28786cb7fc66dc5b374da524c30035bb8a
parent be9a74d2f81b64a46cf70eb402770cc438fcdc53

Simplify and correct bindtodevice().

src/dhcp-common.c

diff --git a/src/dhcp-common.c b/src/dhcp-common.c
index 9e5bfce..d9719d1 100644
--- a/src/dhcp-common.c
+++ b/src/dhcp-common.c
@@ -485,11 +485,8 @@
  
 void  bindtodevice(char *device, int fd)
 {
-  struct ifreq ifr;
-  
-  strcpy(ifr.ifr_name, device);
   /* only allowed by root. */
-  if (setsockopt(fd, SOL_SOCKET, SO_BINDTODEVICE, (void *)&ifr, sizeof(ifr)) == -1 &&
+  if (setsockopt(fd, SOL_SOCKET, SO_BINDTODEVICE, device, IFNAMSIZ) == -1 &&
       errno != EPERM)
     die(_("failed to set SO_BINDTODEVICE on DHCP socket: %s"), NULL, EC_BADNET);
 }