tree bcf07603f72ec624c5fc1085d14c1d1b55d489f1
parent d556b8a5d5bf15d1b9cb7421541878487073ea5e
author Petr Menšík <pemensik@redhat.com> 1614709292 +0000
committer Simon Kelley <simon@thekelleys.org.uk> 1614709292 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEE1urL1u5GuDQkjRESFc3aauGRNaIFAmA+goEACgkQFc3aauGR
 NaIA+BAAjno130y/fWTeg7Anc0GxGe2aOowY/sbllZjwRGjTbbgttACH8gxI0Hgp
 FKlWrNaFLZdTtuQ2OY2K8FYnWteyLmC1bOG1g7OOFA4+2udb1wFIuQEgTjklrljj
 WsV0/Lznd0cBIfln8Ck5EsDXJryVNwLbJrC91Upnmo8DxzdSsAUMOANJSj7vcGdj
 ixAY/8z5pC6xjrvHZd4W1RPCSaSwevZSs6XFLb7jj+WwEWaSdnuPUsISLNCDKhrM
 LU/i1vNTgdDmsT139Uj1f3dFHatn7gtC/ADhyNEJBcAR8y+85Bv+vK750HlmayQM
 g5gXxs/E4a+nvQ7D6pFAdyyog3AP7E0xlCvAOFPcfG3US7Ln9As1aM4l556czTMR
 NmjaZB/RcBSIu+WI7Xy/NuhT8HcTbTvdYSF70bZoyts3afIXtmBcF1yJmPZMWD0s
 K4rYy3yToWJDbCxb53asjdFV7GjV9gZr2BueWkDTbYTW+KNvrhVas6dwsCukdF1v
 ELcOX5FP+nQ2U19GWHZzIp1N6k72dKctEYRgDKvOX8glWitf2IkRc7MgtR+Tis7v
 H8R35kWRbrokmMYHrNGLbBt1K3u7f+deK9dIzbsWAkXNExouOvM49v39UJkTZNVV
 uIvSWlQLPomHOZ9wRmTp1BwYCgYq7xEStfaBhFBiH5Jf5Y6+PSY=
 =qCDK
 -----END PGP SIGNATURE-----

Correct occasional --bind-dynamic synchronization break

Request only one re-read of addresses and/or routes

Previous implementation re-reads systemd addresses exactly the same
number of time equal number of notifications received.
This is not necessary, we need just notification of change, then re-read
the current state and adapt listeners. Repeated re-reading slows netlink
processing and highers CPU usage on mass interface changes.

Continue reading multicast events from netlink, even when ENOBUFS
arrive. Broadcasts are not trusted anyway and refresh would be done in
iface_enumerate. Save queued events sent again.

Remove sleeping on netlink ENOBUFS

With reduced number of written events netlink should receive ENOBUFS
rarely. It does not make sense to wait if it is received. It is just a
signal some packets got missing. Fast reading all pending packets is required,
seq checking ensures it already. Finishes changes by
commit 1d07667ac77c55b9de56b1b2c385167e0e0ec27a.

Move restart from iface_enumerate to enumerate_interfaces

When ENOBUFS is received, restart of reading addresses is done. But
previously found addresses might not have been found this time. In order
to catch this, restart both IPv4 and IPv6 enumeration with clearing
found interfaces first. It should deliver up-to-date state also after
ENOBUFS.

Read all netlink messages before netlink restart

Before writing again into netlink socket, try fetching all pending
messages. They would be ignored, only might trigger new address
synchronization. Should ensure new try has better chance to succeed.

ENOBUFS error handling was improved. Netlink is correctly drained before
sending a new request again. It seems ENOBUFS supression is no longer
necessary or wanted. Let kernel tell us when it failed and handle it a
good way.