tree c40f496d398cc0488860fab99bad0941fbe18967
parent 84a01bee10250b7594efc3bee8fcda156d9a1d5a
author Simon Kelley <simon@thekelleys.org.uk> 1515276991 +0000
committer Simon Kelley <simon@thekelleys.org.uk> 1515276991 +0000

Handle duplicate RRs in DNSSEC validation.

RFC 4034 says:
  [RFC2181] specifies that an RRset is not allowed to contain duplicate
  records (multiple RRs with the same owner name, class, type, and
  RDATA).  Therefore, if an implementation detects duplicate RRs when
  putting the RRset in canonical form, it MUST treat this as a protocol
  error.  If the implementation chooses to handle this protocol error
  in the spirit of the robustness principle (being liberal in what it
  accepts), it MUST remove all but one of the duplicate RR(s) for the
  purposes of calculating the canonical form of the RRset.

We chose to handle this robustly, having found at least one recursive
server in the wild which returns duplicate NSEC records in the AUTHORITY
section of an answer generated from a wildcard record. sort_rrset() is
therefore modified to delete duplicate RRs which are detected almost
for free during the bubble-sort process.

Thanks to Toralf Förster for helping to diagnose this problem.