Eric Andersen | 0139ca9 | 2001-07-22 23:01:03 +0000 | [diff] [blame] | 1 | /* vi: set sw=4 ts=4: */ |
| 2 | /* |
Robert Griebl | aead70b | 2002-07-26 15:54:20 +0000 | [diff] [blame] | 3 | * Modprobe written from scratch for BusyBox |
Eric Andersen | 60e56f5 | 2002-04-26 06:04:01 +0000 | [diff] [blame] | 4 | * |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 5 | * Copyright (c) 2008 Timo Teras <timo.teras@iki.fi> |
| 6 | * Copyright (c) 2008 Vladimir Dronnikov |
Robert Griebl | 6859d76 | 2002-08-05 02:57:12 +0000 | [diff] [blame] | 7 | * |
Rob Landley | 79e1cab | 2005-11-15 00:08:29 +0000 | [diff] [blame] | 8 | * Licensed under GPLv2 or later, see file LICENSE in this tarball for details. |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 9 | */ |
Eric Andersen | 0139ca9 | 2001-07-22 23:01:03 +0000 | [diff] [blame] | 10 | |
Denis Vlasenko | b6adbf1 | 2007-05-26 19:00:18 +0000 | [diff] [blame] | 11 | #include "libbb.h" |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 12 | #include "modutils.h" |
Robert Griebl | 52e8d06 | 2002-05-14 23:42:08 +0000 | [diff] [blame] | 13 | #include <sys/utsname.h> |
Bernhard Reutner-Fischer | 2c351a8 | 2006-06-03 19:08:49 +0000 | [diff] [blame] | 14 | #include <fnmatch.h> |
Eric Andersen | 0139ca9 | 2001-07-22 23:01:03 +0000 | [diff] [blame] | 15 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 16 | struct modprobe_option { |
| 17 | char *module; |
| 18 | char *option; |
Eric Andersen | 60e56f5 | 2002-04-26 06:04:01 +0000 | [diff] [blame] | 19 | }; |
| 20 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 21 | struct modprobe_conf { |
| 22 | char probename[MODULE_NAME_LEN]; |
| 23 | llist_t *options; |
| 24 | llist_t *aliases; |
| 25 | #if ENABLE_FEATURE_MODPROBE_BLACKLIST |
| 26 | #define add_to_blacklist(conf, name) llist_add_to(&conf->blacklist, name) |
| 27 | #define check_blacklist(conf, name) (llist_find(conf->blacklist, name) == NULL) |
| 28 | llist_t *blacklist; |
Rob Landley | ae50c6d | 2005-12-15 07:42:13 +0000 | [diff] [blame] | 29 | #else |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 30 | #define add_to_blacklist(conf, name) do {} while (0) |
| 31 | #define check_blacklist(conf, name) (1) |
| 32 | #endif |
| 33 | }; |
Rob Landley | 79e1cab | 2005-11-15 00:08:29 +0000 | [diff] [blame] | 34 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 35 | #define MODPROBE_OPTS "acdlnrt:VC:" USE_FEATURE_MODPROBE_BLACKLIST("b") |
| 36 | enum { |
| 37 | MODPROBE_OPT_INSERT_ALL = (INSMOD_OPT_UNUSED << 0), /* a */ |
| 38 | MODPROBE_OPT_DUMP_ONLY = (INSMOD_OPT_UNUSED << 1), /* c */ |
| 39 | MODPROBE_OPT_D = (INSMOD_OPT_UNUSED << 2), /* d */ |
| 40 | MODPROBE_OPT_LIST_ONLY = (INSMOD_OPT_UNUSED << 3), /* l */ |
| 41 | MODPROBE_OPT_SHOW_ONLY = (INSMOD_OPT_UNUSED << 4), /* n */ |
| 42 | MODPROBE_OPT_REMOVE = (INSMOD_OPT_UNUSED << 5), /* r */ |
| 43 | MODPROBE_OPT_RESTRICT = (INSMOD_OPT_UNUSED << 6), /* t */ |
| 44 | MODPROBE_OPT_VERONLY = (INSMOD_OPT_UNUSED << 7), /* V */ |
| 45 | MODPROBE_OPT_CONFIGFILE = (INSMOD_OPT_UNUSED << 8), /* C */ |
| 46 | MODPROBE_OPT_BLACKLIST = (INSMOD_OPT_UNUSED << 9) * ENABLE_FEATURE_MODPROBE_BLACKLIST, |
| 47 | }; |
| 48 | |
| 49 | static llist_t *loaded; |
| 50 | |
| 51 | static int read_config(struct modprobe_conf *conf, const char *path); |
| 52 | |
| 53 | static void add_option(llist_t **all_opts, const char *module, const char *opts) |
Denis Vlasenko | f45c4f4 | 2008-06-16 04:09:25 +0000 | [diff] [blame] | 54 | { |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 55 | struct modprobe_option *o; |
| 56 | |
| 57 | o = xzalloc(sizeof(struct modprobe_option)); |
| 58 | if (module) |
| 59 | o->module = filename2modname(module, NULL); |
| 60 | o->option = xstrdup(opts); |
| 61 | llist_add_to(all_opts, o); |
Denis Vlasenko | 9ddc8d5 | 2008-05-18 14:39:43 +0000 | [diff] [blame] | 62 | } |
| 63 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 64 | static int FAST_FUNC config_file_action(const char *filename, |
| 65 | struct stat *statbuf UNUSED_PARAM, |
| 66 | void *userdata, |
| 67 | int depth UNUSED_PARAM) |
Rob Landley | 7261575 | 2006-04-10 16:09:52 +0000 | [diff] [blame] | 68 | { |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 69 | struct modprobe_conf *conf = (struct modprobe_conf *) userdata; |
| 70 | RESERVE_CONFIG_BUFFER(modname, MODULE_NAME_LEN); |
| 71 | char *tokens[3]; |
| 72 | parser_t *p; |
| 73 | int rc = TRUE; |
Denis Vlasenko | e1ee48e | 2008-07-29 00:19:44 +0000 | [diff] [blame] | 74 | |
| 75 | if (bb_basename(filename)[0] == '.') |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 76 | goto error; |
Denis Vlasenko | e1ee48e | 2008-07-29 00:19:44 +0000 | [diff] [blame] | 77 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 78 | p = config_open2(filename, fopen_for_read); |
| 79 | if (p == NULL) { |
| 80 | rc = FALSE; |
| 81 | goto error; |
| 82 | } |
Rob Landley | 7261575 | 2006-04-10 16:09:52 +0000 | [diff] [blame] | 83 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 84 | while (config_read(p, tokens, 3, 2, "# \t", PARSE_NORMAL)) { |
| 85 | if (strcmp(tokens[0], "alias") == 0) { |
| 86 | filename2modname(tokens[1], modname); |
| 87 | if (tokens[2] && |
| 88 | fnmatch(modname, conf->probename, 0) == 0) |
| 89 | llist_add_to(&conf->aliases, |
| 90 | filename2modname(tokens[2], NULL)); |
| 91 | } else if (strcmp(tokens[0], "options") == 0) { |
| 92 | if (tokens[2]) |
| 93 | add_option(&conf->options, tokens[1], tokens[2]); |
| 94 | } else if (strcmp(tokens[0], "include") == 0) { |
| 95 | read_config(conf, tokens[1]); |
Denis Vlasenko | f45c4f4 | 2008-06-16 04:09:25 +0000 | [diff] [blame] | 96 | } else if (ENABLE_FEATURE_MODPROBE_BLACKLIST && |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 97 | strcmp(tokens[0], "blacklist") == 0) { |
| 98 | add_to_blacklist(conf, xstrdup(tokens[1])); |
Rob Landley | 7261575 | 2006-04-10 16:09:52 +0000 | [diff] [blame] | 99 | } |
Rob Landley | e919096 | 2005-12-12 19:38:44 +0000 | [diff] [blame] | 100 | } |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 101 | config_close(p); |
| 102 | error: |
Bernhard Reutner-Fischer | e3c150b | 2006-05-19 11:24:28 +0000 | [diff] [blame] | 103 | if (ENABLE_FEATURE_CLEAN_UP) |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 104 | RELEASE_CONFIG_BUFFER(modname); |
Robert Griebl | 52e8d06 | 2002-05-14 23:42:08 +0000 | [diff] [blame] | 105 | return rc; |
| 106 | } |
| 107 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 108 | static int read_config(struct modprobe_conf *conf, const char *path) |
Robert Griebl | 52e8d06 | 2002-05-14 23:42:08 +0000 | [diff] [blame] | 109 | { |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 110 | return recursive_action(path, ACTION_RECURSE | ACTION_QUIET, |
| 111 | config_file_action, NULL, conf, 1); |
| 112 | } |
Eric Andersen | 3b1a744 | 2003-12-24 20:30:45 +0000 | [diff] [blame] | 113 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 114 | static char *gather_options(llist_t *first, const char *module, int usecmdline) |
| 115 | { |
| 116 | struct modprobe_option *opt; |
| 117 | llist_t *n; |
| 118 | char *opts = xstrdup(""); |
| 119 | int optlen = 0; |
Eric Andersen | 3b1a744 | 2003-12-24 20:30:45 +0000 | [diff] [blame] | 120 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 121 | for (n = first; n != NULL; n = n->link) { |
| 122 | opt = (struct modprobe_option *) n->data; |
Eric Andersen | 3b1a744 | 2003-12-24 20:30:45 +0000 | [diff] [blame] | 123 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 124 | if (opt->module == NULL && !usecmdline) |
| 125 | continue; |
| 126 | if (opt->module != NULL && strcmp(opt->module, module) != 0) |
| 127 | continue; |
| 128 | |
| 129 | opts = xrealloc(opts, optlen + strlen(opt->option) + 2); |
| 130 | optlen += sprintf(opts + optlen, "%s ", opt->option); |
| 131 | } |
| 132 | return opts; |
| 133 | } |
| 134 | |
| 135 | static int do_modprobe(struct modprobe_conf *conf, const char *module) |
| 136 | { |
| 137 | RESERVE_CONFIG_BUFFER(modname, MODULE_NAME_LEN); |
| 138 | llist_t *deps = NULL; |
| 139 | char *fn, *options, *colon = NULL, *tokens[2]; |
| 140 | parser_t *p; |
| 141 | int rc = -1; |
| 142 | |
| 143 | p = config_open2(CONFIG_DEFAULT_DEPMOD_FILE, fopen_for_read); |
| 144 | if (p == NULL) |
| 145 | goto error; |
| 146 | |
| 147 | while (config_read(p, tokens, 2, 1, "# \t", PARSE_NORMAL)) { |
| 148 | colon = last_char_is(tokens[0], ':'); |
| 149 | if (colon == NULL) |
| 150 | continue; |
| 151 | |
| 152 | filename2modname(tokens[0], modname); |
| 153 | if (strcmp(modname, module) == 0) |
| 154 | break; |
| 155 | |
| 156 | colon = NULL; |
| 157 | } |
| 158 | if (colon == NULL) |
| 159 | goto error_not_found; |
| 160 | |
| 161 | colon[0] = '\0'; |
| 162 | llist_add_to(&deps, xstrdup(tokens[0])); |
| 163 | if (tokens[1]) |
| 164 | string_to_llist(tokens[1], &deps, " "); |
| 165 | |
| 166 | if (!(option_mask32 & MODPROBE_OPT_REMOVE)) |
| 167 | deps = llist_rev(deps); |
| 168 | |
| 169 | rc = 0; |
| 170 | while (deps && rc == 0) { |
| 171 | fn = llist_pop(&deps); |
| 172 | filename2modname(fn, modname); |
| 173 | if (option_mask32 & MODPROBE_OPT_REMOVE) { |
| 174 | if (bb_delete_module(modname, O_EXCL) != 0) |
| 175 | rc = errno; |
| 176 | } else if (llist_find(loaded, modname) == NULL) { |
| 177 | options = gather_options(conf->options, modname, |
| 178 | strcmp(modname, module) == 0); |
| 179 | rc = bb_init_module(fn, options); |
| 180 | if (rc == 0) |
| 181 | llist_add_to(&loaded, xstrdup(modname)); |
| 182 | if (ENABLE_FEATURE_CLEAN_UP) |
| 183 | free(options); |
| 184 | } |
| 185 | |
| 186 | if (ENABLE_FEATURE_CLEAN_UP) |
| 187 | free(fn); |
| 188 | } |
| 189 | |
| 190 | error_not_found: |
| 191 | config_close(p); |
| 192 | error: |
| 193 | if (ENABLE_FEATURE_CLEAN_UP) |
| 194 | RELEASE_CONFIG_BUFFER(modname); |
| 195 | if (rc > 0 && !(option_mask32 & INSMOD_OPT_SILENT)) |
Denis Vlasenko | 54d1005 | 2008-12-24 03:11:43 +0000 | [diff] [blame] | 196 | bb_error_msg("failed to %sload module %s: %s", |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 197 | (option_mask32 & MODPROBE_OPT_REMOVE) ? "un" : "", |
| 198 | module, moderror(rc)); |
Eric Andersen | 908e362 | 2003-06-20 09:56:37 +0000 | [diff] [blame] | 199 | return rc; |
Robert Griebl | 52e8d06 | 2002-05-14 23:42:08 +0000 | [diff] [blame] | 200 | } |
| 201 | |
Denis Vlasenko | 9b49a5e | 2007-10-11 10:05:36 +0000 | [diff] [blame] | 202 | int modprobe_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; |
Denis Vlasenko | 9ddc004 | 2008-08-06 00:51:43 +0000 | [diff] [blame] | 203 | int modprobe_main(int argc UNUSED_PARAM, char **argv) |
Eric Andersen | 0139ca9 | 2001-07-22 23:01:03 +0000 | [diff] [blame] | 204 | { |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 205 | struct utsname uts; |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 206 | int rc; |
| 207 | unsigned opt; |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 208 | llist_t *options = NULL; |
Eric Andersen | 0139ca9 | 2001-07-22 23:01:03 +0000 | [diff] [blame] | 209 | |
Denis Vlasenko | e7fca51 | 2007-11-10 01:32:18 +0000 | [diff] [blame] | 210 | opt_complementary = "q-v:v-q"; |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 211 | opt = getopt32(argv, INSMOD_OPTS MODPROBE_OPTS INSMOD_ARGS, |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 212 | NULL, NULL); |
Denis Vlasenko | 9ddc004 | 2008-08-06 00:51:43 +0000 | [diff] [blame] | 213 | argv += optind; |
Denis Vlasenko | b68979a | 2007-11-02 23:31:10 +0000 | [diff] [blame] | 214 | |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 215 | if (opt & (MODPROBE_OPT_DUMP_ONLY | MODPROBE_OPT_LIST_ONLY | |
| 216 | MODPROBE_OPT_SHOW_ONLY)) |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 217 | bb_error_msg_and_die("not supported"); |
Robert Griebl | 236abbf | 2002-05-22 23:34:35 +0000 | [diff] [blame] | 218 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 219 | /* goto modules location */ |
| 220 | xchdir(CONFIG_DEFAULT_MODULES_DIR); |
| 221 | uname(&uts); |
| 222 | xchdir(uts.release); |
Robert Griebl | 52e8d06 | 2002-05-14 23:42:08 +0000 | [diff] [blame] | 223 | |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 224 | if (!argv[0]) { |
| 225 | if (opt & MODPROBE_OPT_REMOVE) { |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 226 | if (bb_delete_module(NULL, O_NONBLOCK|O_EXCL) != 0) |
| 227 | bb_perror_msg_and_die("rmmod"); |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 228 | } |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 229 | return EXIT_SUCCESS; |
| 230 | } |
| 231 | if (!(opt & MODPROBE_OPT_INSERT_ALL)) { |
| 232 | /* If not -a, we have only one module name, |
| 233 | * the rest of parameters are options */ |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 234 | add_option(&options, NULL, parse_cmdline_module_options(argv)); |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 235 | argv[1] = NULL; |
Eric Andersen | 0139ca9 | 2001-07-22 23:01:03 +0000 | [diff] [blame] | 236 | } |
| 237 | |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 238 | /* cache modules */ |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 239 | { |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 240 | char *s; |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 241 | parser_t *parser = config_open2("/proc/modules", fopen_for_read); |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 242 | while (config_read(parser, &s, 1, 1, "# \t", PARSE_NORMAL & ~PARSE_GREEDY)) |
| 243 | llist_add_to(&loaded, xstrdup(s)); |
| 244 | config_close(parser); |
| 245 | } |
Eric Andersen | 3b1a744 | 2003-12-24 20:30:45 +0000 | [diff] [blame] | 246 | |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 247 | while (*argv) { |
| 248 | const char *arg = *argv; |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 249 | struct modprobe_conf *conf; |
| 250 | |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 251 | conf = xzalloc(sizeof(*conf)); |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 252 | conf->options = options; |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 253 | filename2modname(arg, conf->probename); |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 254 | read_config(conf, "/etc/modprobe.conf"); |
| 255 | read_config(conf, "/etc/modprobe.d"); |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 256 | if (ENABLE_FEATURE_MODUTILS_SYMBOLS |
| 257 | && conf->aliases == NULL |
| 258 | && strncmp(arg, "symbol:", 7) == 0 |
| 259 | ) { |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 260 | read_config(conf, "modules.symbols"); |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 261 | } |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 262 | |
| 263 | if (ENABLE_FEATURE_MODUTILS_ALIAS && conf->aliases == NULL) |
| 264 | read_config(conf, "modules.alias"); |
| 265 | |
| 266 | if (conf->aliases == NULL) { |
| 267 | /* Try if module by literal name is found; literal |
| 268 | * names are blacklist only if '-b' is given. */ |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 269 | if (!(opt & MODPROBE_OPT_BLACKLIST) || |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 270 | check_blacklist(conf, conf->probename)) { |
| 271 | rc = do_modprobe(conf, conf->probename); |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 272 | if (rc < 0 && !(opt & INSMOD_OPT_SILENT)) |
Denis Vlasenko | 54d1005 | 2008-12-24 03:11:43 +0000 | [diff] [blame] | 273 | bb_error_msg("module %s not found", arg); |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 274 | } |
| 275 | } else { |
| 276 | /* Probe all aliases */ |
| 277 | while (conf->aliases != NULL) { |
| 278 | char *realname = llist_pop(&conf->aliases); |
| 279 | if (check_blacklist(conf, realname)) |
| 280 | do_modprobe(conf, realname); |
| 281 | if (ENABLE_FEATURE_CLEAN_UP) |
| 282 | free(realname); |
| 283 | } |
| 284 | } |
Denis Vlasenko | bb26db4 | 2008-10-31 02:04:28 +0000 | [diff] [blame] | 285 | argv++; |
Denis Vlasenko | ba1315d | 2008-09-13 14:59:38 +0000 | [diff] [blame] | 286 | } |
| 287 | |
| 288 | return EXIT_SUCCESS; |
Eric Andersen | 0139ca9 | 2001-07-22 23:01:03 +0000 | [diff] [blame] | 289 | } |