| Matthew Smith | 768c290 | 2018-09-11 13:50:48 -0500 | [diff] [blame] | 1 | From ba9b381c532fe57c726752b7db0ab45ab7726c90 Mon Sep 17 00:00:00 2001 |
| 2 | From: Matthew Smith <mgsmith@netgate.com> |
| 3 | Date: Fri, 13 Jul 2018 16:35:57 -0500 |
| 4 | Subject: [PATCH] ixgbe: wait longer for link after fiber MAC setup |
| 5 | |
| 6 | After setting up the link on a fiber port, the maximum wait time for |
| 7 | the link to come up is 500 ms in ixgbe_setup_mac_link_multispeed_fiber(). |
| 8 | On an x550 SFP+ port, this is often not sufficiently long for the link |
| 9 | to come up. This can result in never being able to retrieve accurate |
| 10 | link status for the port using rte_eth_link_get_nowait(). |
| 11 | |
| 12 | Increase the maximum wait time in ixgbe_setup_mac_link_multispeed_fiber() |
| 13 | to 1 s. |
| 14 | |
| 15 | Bugzilla ID: 69 |
| 16 | Fixes: f3430431abaf ("ixgbe/base: add SFP+ dual-speed support") |
| 17 | Cc: stable@dpdk.org |
| 18 | |
| 19 | Signed-off-by: Matthew Smith <mgsmith@netgate.com> |
| 20 | --- |
| 21 | drivers/net/ixgbe/base/ixgbe_common.c | 2 +- |
| 22 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 23 | |
| 24 | diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c |
| 25 | index e7e9256e5..2fb0a072c 100644 |
| 26 | --- a/drivers/net/ixgbe/base/ixgbe_common.c |
| 27 | +++ b/drivers/net/ixgbe/base/ixgbe_common.c |
| 28 | @@ -5296,7 +5296,7 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw, |
| 29 | * Section 73.10.2, we may have to wait up to 500ms if KR is |
| 30 | * attempted. 82599 uses the same timing for 10g SFI. |
| 31 | */ |
| 32 | - for (i = 0; i < 5; i++) { |
| 33 | + for (i = 0; i < 10; i++) { |
| 34 | /* Wait for the link partner to also set speed */ |
| 35 | msec_delay(100); |
| 36 | |
| 37 | -- |
| 38 | 2.15.2 (Apple Git-101.1) |
| 39 | |