blob: 07b6bbf7f4b753fe51a9613f834d50fb5f6724ed [file] [log] [blame]
Ole Troan5c318c72020-05-05 12:23:47 +02001#!/bin/sh
2set -eux
3
4TMPDIR=$(mktemp -d /tmp/vpp-crccheck-test-XXXXX)
5
6CURR_ROOT=$(git rev-parse --show-toplevel)
7CURR_DIR=$(pwd)
8
9verify_check_patchset_fails() {
10 if (extras/scripts/crcchecker.py --check-patchset); then
11 echo "ERROR - check succeeded, it should have failed!"
12 exit 1;
13 fi
14}
15
16finish() {
17 if [ -e "$TMPDIR" ]; then
18 echo "Temporary directory is: $TMPDIR"
19 fi
20}
21trap finish EXIT
22
23
24# make a copy of the current repo that we can play with
25cd ${TMPDIR}
26mkdir misc-files
27git clone ${CURR_ROOT} vpp-uut
28cd vpp-uut
29
30# maybe grab the CRC checker
31# git fetch "https://gerrit.fd.io/r/vpp" refs/changes/81/26881/14 && git cherry-pick FETCH_HEAD || echo "Already there"
32
33
34echo "TEST 1: Check the current patchset..."
35extras/scripts/crcchecker.py --check-patchset
36
37echo "TEST 2: Dumping the current manifest..."
38extras/scripts/crcchecker.py --dump-manifest >${TMPDIR}/misc-files/manifest.txt
39
40echo "TEST 3: Checking the 20.01 version of acl.api...."
41extras/scripts/crcchecker.py --git-revision v20.01 src/plugins/acl/acl.api
42
43echo "TEST 4: Add a new field into a message in acl.api, and check patchset - must fail..."
44sed -i -e 's#vpe_pid;#vpe_pid; u32 sneaky_new_field;#' src/plugins/acl/acl.api
45verify_check_patchset_fails
46
47echo "TEST 5: Rename the changed acl.api file and not add it to git... must fail (due to deletion of the APIs)..."
48mv src/plugins/acl/acl.api src/plugins/acl/acl_new.api
49verify_check_patchset_fails
50
51echo "TEST 6: Add the renamed file to git commit... must fail (due to addition of the fields)..."
52git add src/plugins/acl/acl_new.api
53git commit -m "added acl_new.api"
54verify_check_patchset_fails
55
56echo "TEST 7: Verify we can delete deprecated message"
57git commit -a -m "reset"
58cat >crccheck.api <<EOL
59option version="1.0.0";
60autoreply define crccheck
61{
Ole Troan68ebcd52020-08-10 17:06:44 +020062 option deprecated;
Ole Troan5c318c72020-05-05 12:23:47 +020063 bool foo;
64};
65EOL
66git add crccheck.api
67git commit -m "deprecated api";
68# delete API
69cat >crccheck.api <<EOL
70option version="1.0.0";
71autoreply define crccheck_2
72{
73 bool foo;
74};
75EOL
76git add crccheck.api
77git commit -m "deprecated api";
78extras/scripts/crcchecker.py --check-patchset
79
80echo "TEST 8: Verify that we can not rename a non-deprecated message"
81sed -i -e 's/crccheck_2/crccheck_3/g' crccheck.api
82git add crccheck.api
83git commit -m "renamed api";
84verify_check_patchset_fails
85# fix it.
86sed -i -e 's/crccheck_3/crccheck_2/g' crccheck.api
87git commit -a --amend -m "empty commit after we renamed api back" --allow-empty
88
89echo "TEST 9: Verify that the check fails if the changes are not committed"
90cat >>crccheck.api <<EOL
91autoreply define crc_new_check_in_progress
92{
93 option status="in_progress";
94 bool foobar;
95};
96EOL
97verify_check_patchset_fails
98
99echo "TEST10: Verify that the in-progress message can be added"
100git add crccheck.api
101git commit -m "added a new in-progress api";
102extras/scripts/crcchecker.py --check-patchset
103
104echo "TEST11: Verify we can rename an in-progress API"
105sed -i -e 's/crc_new_check_in_progress/crc_new_check_in_progress_2/g' crccheck.api
106git add crccheck.api
107git commit -m "renamed in-progress api";
108extras/scripts/crcchecker.py --check-patchset
109
110echo "TEST12: Verify we can add a field to an in-progress API"
111sed -i -e 's/foobar;/foobar; bool new_baz;/g' crccheck.api
112git add crccheck.api
113git commit -m "new field added in in-progress api";
114extras/scripts/crcchecker.py --check-patchset
115
116echo "TEST13: Verify we fail the check if the file can not be compiled"
117cat >crccheck2.api <<EOL
118option version="0.0.1";
119autoreply define spot_the_error
120{
121 option status="in_progress"
122 bool something_important;
123};
124EOL
125git add crccheck2.api
126git commit -m "a new message with a syntax error";
127verify_check_patchset_fails
128
129# get rid of the "erroneous" commit in the previous test
130git reset --hard HEAD~1
131
Ole Troandeecc932020-05-19 12:33:00 +0200132echo "TEST14: Verify we handle new .api file"
133cat >crccheck3.api <<EOL
134autoreply define foo
135{
136 bool bar;
137};
138EOL
139git add crccheck3.api
140git commit -m "a new message in new file";
141extras/scripts/crcchecker.py --check-patchset
142
Ole Troan5c318c72020-05-05 12:23:47 +0200143echo "TEST: All tests got the expected result, cleaning up."
144
145# done with all the tests - clean up
146cd ${CURR_DIR}
147
148# beware of empty variables, careful with deletion
149rm -rf ${TMPDIR}/vpp-uut
150rm -rf ${TMPDIR}/misc-files
151rmdir ${TMPDIR}